Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ⬆️ gomod to v1.56.3 - autoclosed #123

Conversation

mend-for-github-com[bot]
Copy link
Contributor

@mend-for-github-com mend-for-github-com bot commented Dec 21, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google.golang.org/grpc v1.55.0 -> v1.56.3 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

GHSA-m425-mq94-257g

Impact

In affected releases of gRPC-Go, it is possible for an attacker to send HTTP/2 requests, cancel them, and send subsequent requests, which is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to launch more concurrent method handlers than the configured maximum stream limit.

Patches

This vulnerability was addressed by #​6703 and has been included in patch releases: 1.56.3, 1.57.1, 1.58.3. It is also included in the latest release, 1.59.0.

Along with applying the patch, users should also ensure they are using the grpc.MaxConcurrentStreams server option to apply a limit to the server's resources used for any single connection.

Workarounds

None.

References

#​6703

CVE-2023-44487

HTTP/2 Rapid reset attack

The HTTP/2 protocol allows clients to indicate to the server that a previous stream should be canceled by sending a RST_STREAM frame. The protocol does not require the client and server to coordinate the cancellation in any way, the client may do it unilaterally. The client may also assume that the cancellation will take effect immediately when the server receives the RST_STREAM frame, before any other data from that TCP connection is processed.

Abuse of this feature is called a Rapid Reset attack because it relies on the ability for an endpoint to send a RST_STREAM frame immediately after sending a request frame, which makes the other endpoint start working and then rapidly resets the request. The request is canceled, but leaves the HTTP/2 connection open.

The HTTP/2 Rapid Reset attack built on this capability is simple: The client opens a large number of streams at once as in the standard HTTP/2 attack, but rather than waiting for a response to each request stream from the server or proxy, the client cancels each request immediately.

The ability to reset streams immediately allows each connection to have an indefinite number of requests in flight. By explicitly canceling the requests, the attacker never exceeds the limit on the number of concurrent open streams. The number of in-flight requests is no longer dependent on the round-trip time (RTT), but only on the available network bandwidth.

In a typical HTTP/2 server implementation, the server will still have to do significant amounts of work for canceled requests, such as allocating new stream data structures, parsing the query and doing header decompression, and mapping the URL to a resource. For reverse proxy implementations, the request may be proxied to the backend server before the RST_STREAM frame is processed. The client on the other hand paid almost no costs for sending the requests. This creates an exploitable cost asymmetry between the server and the client.

Multiple software artifacts implementing HTTP/2 are affected. This advisory was originally ingested from the swift-nio-http2 repo advisory and their original conent follows.

swift-nio-http2 specific advisory

swift-nio-http2 is vulnerable to a denial-of-service vulnerability in which a malicious client can create and then reset a large number of HTTP/2 streams in a short period of time. This causes swift-nio-http2 to commit to a large amount of expensive work which it then throws away, including creating entirely new Channels to serve the traffic. This can easily overwhelm an EventLoop and prevent it from making forward progress.

swift-nio-http2 1.28 contains a remediation for this issue that applies reset counter using a sliding window. This constrains the number of stream resets that may occur in a given window of time. Clients violating this limit will have their connections torn down. This allows clients to continue to cancel streams for legitimate reasons, while constraining malicious actors.


Release Notes

grpc/grpc-go (google.golang.org/grpc)

v1.56.3: Release 1.56.3

Compare Source

Security

  • server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)

    In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.

v1.56.2: Release 1.56.2

Compare Source

  • status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#​6374)

v1.56.1: Release 1.56.1

Compare Source

  • client: handle empty address lists correctly in addrConn.updateAddrs

v1.56.0: Release 1.56.0

Compare Source

New Features

  • client: support channel idleness using WithIdleTimeout dial option (#​6263)
    • This feature is currently disabled by default, but will be enabled with a 30 minute default in the future.
  • client: when using pickfirst, keep channel state in TRANSIENT_FAILURE until it becomes READY (gRFC A62) (#​6306)
  • xds: Add support for Custom LB Policies (gRFC A52) (#​6224)
  • xds: support pick_first Custom LB policy (gRFC A62) (#​6314) (#​6317)
  • client: add support for pickfirst address shuffling (gRFC A62) (#​6311)
  • xds: Add support for String Matcher Header Matcher in RDS (#​6313)
  • xds/outlierdetection: Add Channelz Logger to Outlier Detection LB (#​6145)
  • xds: enable RLS in xDS by default (#​6343)
  • orca: add support for application_utilization field and missing range checks on several metrics setters
  • balancer/weightedroundrobin: add new LB policy for balancing between backends based on their load reports (gRFC A58) (#​6241)
  • authz: add conversion of json to RBAC Audit Logging config (#​6192)
  • authz: add support for stdout logger (#​6230 and #​6298)
  • authz: support customizable audit functionality for authorization policy (#​6192 #​6230 #​6298 #​6158 #​6304 and #​6225)

Bug Fixes

  • orca: fix a race at startup of out-of-band metric subscriptions that would cause the report interval to request 0 (#​6245)
  • xds/xdsresource: Fix Outlier Detection Config Handling and correctly set xDS Defaults (#​6361)
  • xds/outlierdetection: Fix Outlier Detection Config Handling by setting defaults in ParseConfig() (#​6361)

API Changes

  • orca: allow a ServerMetricsProvider to be passed to the ORCA service and ServerOption (#​6223)

v1.55.1: Release 1.55.1

Compare Source

  • status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#​6374)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 449 lines in your changes are missing coverage. Please review.

Comparison is base (a2521eb) 32.61% compared to head (d954733) 44.88%.
Report is 74 commits behind head on main.

Files Patch % Lines
commands/siem.go 0.00% 68 Missing ⚠️
internal/store/secure_store.go 0.00% 52 Missing ⚠️
internal/store/credential-helpers/pass.go 8.51% 43 Missing ⚠️
tests/fake/fake_store.go 15.21% 39 Missing ⚠️
commands/base.go 6.45% 29 Missing ⚠️
commands/byok.go 64.38% 26 Missing ⚠️
commands/engine.go 31.57% 26 Missing ⚠️
internal/store/file_store.go 56.89% 19 Missing and 6 partials ⚠️
commands/pool.go 25.00% 21 Missing ⚠️
commands/user.go 75.29% 18 Missing and 3 partials ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #123       +/-   ##
===========================================
+ Coverage   32.61%   44.88%   +12.27%     
===========================================
  Files          80       86        +6     
  Lines       10855    11880     +1025     
===========================================
+ Hits         3540     5332     +1792     
+ Misses       7027     6329      -698     
+ Partials      288      219       -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/go-google.golang.org/grpc-vulnerability branch 6 times, most recently from 59a829a to 4a24dbc Compare December 22, 2023 11:14
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/go-google.golang.org/grpc-vulnerability branch from 4a24dbc to d954733 Compare December 22, 2023 11:19
@mend-for-github-com mend-for-github-com bot changed the title chore(deps): update ⬆️ gomod to v1.56.3 chore(deps): update ⬆️ gomod to v1.56.3 - autoclosed Jan 10, 2024
auto-merge was automatically disabled January 10, 2024 16:35

Pull request was closed

@mend-for-github-com mend-for-github-com bot deleted the whitesource-remediate/go-google.golang.org/grpc-vulnerability branch January 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants