Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands): do not transfrom string answer to integer #135

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

andrii-zakurenyi
Copy link
Contributor

@andrii-zakurenyi andrii-zakurenyi commented Mar 22, 2024

In the last version of the AlecAivazis/survey library the "Cleanup" method on input answer requires string, not int. This is a breaking change from them, but in their README it says that the project is no longer maintained, so lucky us, no more braking changes.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.13%. Comparing base (a2521eb) to head (8fa6c09).
Report is 92 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #135       +/-   ##
===========================================
+ Coverage   32.61%   51.13%   +18.52%     
===========================================
  Files          80       87        +7     
  Lines       10855    11948     +1093     
===========================================
+ Hits         3540     6110     +2570     
+ Misses       7027     5539     -1488     
- Partials      288      299       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-zakurenyi andrii-zakurenyi merged commit 53bd7c0 into main Mar 22, 2024
14 checks passed
@andrii-zakurenyi andrii-zakurenyi deleted the az-fix-usage-of-survey-lib branch March 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants