Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: changed sha1 calls to sha256 #147

Merged
merged 6 commits into from
Jul 18, 2024
Merged

security: changed sha1 calls to sha256 #147

merged 6 commits into from
Jul 18, 2024

Conversation

pacificcode
Copy link
Contributor

@pacificcode pacificcode commented Jul 18, 2024

  • Fixes AB#580903
  • Golangci-lint upgraded to latest schema, which should eliminate the issues in lint failure.

@pacificcode pacificcode requested a review from a team as a code owner July 18, 2024 15:22
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.29%. Comparing base (a2521eb) to head (8ba5c6e).
Report is 111 commits behind head on main.

Files Patch % Lines
commands/secret.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   32.61%   25.29%   -7.33%     
==========================================
  Files          80       79       -1     
  Lines       10855    11091     +236     
==========================================
- Hits         3540     2805     -735     
- Misses       7027     8015     +988     
+ Partials      288      271      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sheldonhull
Copy link
Contributor

sheldonhull commented Jul 18, 2024

@pacificcode i relaunched the test task. Might be a flaky test, so if you see that type of failure in the future that isn't reproduced locally, just open the run and "rerun failed steps" and maybe it will go away.

The end-to-end and integration test pending is probably because of the filtering that only triggers on Go file updates, but i also found a typo in the trigger fix I pushed and am pushing now to see if it eliminates the problems.

edit: confirmed it was a yaml issue, and now with new push it triggered the integration tests correctly, should post shortly.

@sheldonhull sheldonhull enabled auto-merge (squash) July 18, 2024 21:28
@sheldonhull sheldonhull merged commit 066f862 into main Jul 18, 2024
13 checks passed
@sheldonhull sheldonhull deleted the bh.sha256 branch July 18, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants