-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: [snyk] modified .snyk policy file to exclude vendor/github.com/Azure/go-auto… #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ A changie entry is required in .changes/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ changie entry was found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending, let's check before merging another rule on why it's not honoring subfolders.
@@ -4,5 +4,6 @@ ignore: {} | |||
patch: {} | |||
exclude: | |||
global: | |||
- vendor/github.com/Azure/go-autorest/Gopkg.lock | |||
- vendor/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge this let's figure out why it's not working, since you should only have to specify a folder, not a subfolder. This list should be minimal so lets look at docs and then if that doesn't answer, reach out to security team on why it's not working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheldonhull security team is aware of this issue. Alexa Kessler did her homework on this issue and verified with with Snyk representatives. She would be the source of authority for any further/specific details.
This PR's primary function is to test if including this single file in the .snyk policy file "exclude" directive will eliminate the snyk web UI from reporting these "High" level vulnerabilities. FYI, the snyk cli does not report the vulnerabilities being addressed by this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pacificcode I'm discussing with Alexa for some context before merging since there's some research I did on this prior that might have relevance. Once I confirm with her I'll either approve or update here with more context, so leave this open temporarily and I'll resolve it once I get some details to add. Didn't want you to think I'd forgotten :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheldonhull any update on this? it would be great to get it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same update from 2 weeks ago. I did bump the internal conversation and will update once I have something more, or you can bump that thread as well. 🙇🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ changie entry was found
@@ -4,5 +4,6 @@ ignore: {} | |||
patch: {} | |||
exclude: | |||
global: | |||
- vendor/github.com/Azure/go-autorest/Gopkg.lock | |||
- vendor/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pacificcode I'm discussing with Alexa for some context before merging since there's some research I did on this prior that might have relevance. Once I confirm with her I'll either approve or update here with more context, so leave this open temporarily and I'll resolve it once I get some details to add. Didn't want you to think I'd forgotten :-)
🤖 This is being marked as stale due to no recent activity. Reopening will require project contributor to reopen. |
modified .snyk policy file to exclude vendor/github.com/Azure/go-autorest/Gopkg.lock