Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: [snyk] modified .snyk policy file to exclude vendor/github.com/Azure/go-auto… #169

Closed
wants to merge 3 commits into from

Conversation

pacificcode
Copy link
Contributor

modified .snyk policy file to exclude vendor/github.com/Azure/go-autorest/Gopkg.lock

@pacificcode pacificcode requested a review from a team as a code owner August 26, 2024 14:12
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ A changie entry is required in .changes/

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ changie entry was found

Copy link
Contributor

@sheldonhull sheldonhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending, let's check before merging another rule on why it's not honoring subfolders.

@@ -4,5 +4,6 @@ ignore: {}
patch: {}
exclude:
global:
- vendor/github.com/Azure/go-autorest/Gopkg.lock
- vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this let's figure out why it's not working, since you should only have to specify a folder, not a subfolder. This list should be minimal so lets look at docs and then if that doesn't answer, reach out to security team on why it's not working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheldonhull security team is aware of this issue. Alexa Kessler did her homework on this issue and verified with with Snyk representatives. She would be the source of authority for any further/specific details.
This PR's primary function is to test if including this single file in the .snyk policy file "exclude" directive will eliminate the snyk web UI from reporting these "High" level vulnerabilities. FYI, the snyk cli does not report the vulnerabilities being addressed by this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pacificcode I'm discussing with Alexa for some context before merging since there's some research I did on this prior that might have relevance. Once I confirm with her I'll either approve or update here with more context, so leave this open temporarily and I'll resolve it once I get some details to add. Didn't want you to think I'd forgotten :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheldonhull any update on this? it would be great to get it merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same update from 2 weeks ago. I did bump the internal conversation and will update once I have something more, or you can bump that thread as well. 🙇🏻

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ changie entry was found

@@ -4,5 +4,6 @@ ignore: {}
patch: {}
exclude:
global:
- vendor/github.com/Azure/go-autorest/Gopkg.lock
- vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pacificcode I'm discussing with Alexa for some context before merging since there's some research I did on this prior that might have relevance. Once I confirm with her I'll either approve or update here with more context, so leave this open temporarily and I'll resolve it once I get some details to add. Didn't want you to think I'd forgotten :-)

@github-actions github-actions bot added the stale label Sep 10, 2024
Copy link
Contributor

🤖 This is being marked as stale due to no recent activity. Reopening will require project contributor to reopen.

@github-actions github-actions bot closed this Sep 15, 2024
@pacificcode pacificcode deleted the bh.snyk.ignore branch September 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants