Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traitor reputation real #2913

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Feb 7, 2025

About the PR

real...

based on this design doc but objectives can be freely picked instead of forced. offerings are random but you can reject ones you dont like for a longer cooldown than taking them and completing (no cost its just time)

instead of just taking item youll have to extract it with a syndicate fulton, a fulton with a cooldown of a minute that sends things to the syndie vault
adds ransom objectives for fultoning someone. they can just right click to remove it so you will have to keep them cuffed too. they get sent to the syndie jail until ransom gets paid :trollface:

ransoms for people start at 10k and can be modified like so:

- 50% if they went crit - 20% if they died, objective failed too - 50% for passengers, theyre not nt employees who cares - 2x for sec, 2.5x for warden - 3x for most command, 2x for LO since its harder to pay the ransom without one probably - 4x for hos - 5x for cap - 10x if you somehow manage to both have centcom and steal them

todo:

  • buying back ransomed mobs
  • non-meme guidebook

to be done later:

  • data knife objective
  • something to make nuke disk objective not cuck loneops
  • idk port more stuff from tg

Why / Balance

always stay evil

old system bad from a gameplay perspective:

  • get your greentext 10 minutes in and do nothing for the rest of the round
  • sec gets a cold case and the traitor does nothing anymore, so sec has nothing to do and goes cryo

high end gear like bloodred and china lake are gated behind high reputation so you have to do smaller tasks before going to war with sec, by which time they should have plenty of reasons to have arrested you already, leading to a more cat and mouse of constant antagonism rather than do the funny thing once and forget you were ever a traitor

Technical details

:trollface:

Media

current syndie prison
10:27:10

contract button real
11:18:53

uplink stuff

you can always buy ammo

11:29:43

surplus is unaffected stay gambling

11:30:52

some stuff with 0 rep

11:30:41

11:30:25

11:29:49

no automatic objectives anymore
09:43:28

current contracts ui :trollface:
11:32:03

paid for completing contract real
03:53:57

greentext...
10:45:38
10:46:13

level up real
11:58:39

ransomed...
12:39:31

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

anything added to uplink in the future will need reputation added

Changelog
🆑

  • add: Completely reworked traitors to use the new contracts system. Read the guidebook!
  • remove: Removed the nuke disk objective until it doesn't softlock nukies.

@deltanedas deltanedas requested a review from a team February 7, 2025 00:08
@github-actions github-actions bot added size/XL Over 1024 lines S: Needs Review Changes: YML Changes any yml files Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Feb 7, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 7, 2025

Is this draft running yet? Gonna test whenever it is

@deltanedas
Copy link
Member Author

client doesnt compile and it fails to pick objectives

@Spielern
Copy link
Contributor

Spielern commented Feb 7, 2025

holy shit??? this is actually incredible

@AftrLite
Copy link
Contributor

AftrLite commented Feb 7, 2025

Fascinating

@kipdotnet
Copy link

Oh this is really cool. Putting a bookmark on this

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 10, 2025
@Lyndomen
Copy link
Contributor

@Lyndomen stuff mostly works now you can try it out locally (extraction objectives require sudo cvar shuttle.emergency true then restarting the round)

Thanks pro, will get feedback by this time tmrw

@Lyndomen
Copy link
Contributor

image

syndie jail looks really nice, good mapping. Taser needs a recharger. jail could use windoors to pass the gremlins food, actually looking at it rn u probably didnt intend to have this map be reviewed yet so im gonna not nitpick 😎

uplink implant auto assigned me a traitor objective when i spawned in with it

@deltanedas
Copy link
Member Author

uplink implant doesnt support contracts (yet) so you would have an uplink with no objectives which is bad

theres still work to do for the prison like adding the marshal ghost role :trollface:
and removing headsets so funny prisoners dont ask john centcom for help

@DieselMohawk
Copy link
Contributor

I was discussing with my lads and they brought up a fair point:

Where's the paper trail that someone stole something? Couldn't they just "miracle" it away since it only takes a minute to fulton away the item. Is there any way to get it back? Also wouldn't this make all steal objective's objectively easier since they can just fulton it off?

@Lyndomen
Copy link
Contributor

Where's the paper trail that someone stole something?
Is there any way to get it back?
Also wouldn't this make all steal objective's objectively easier since they can just fulton it off?

Some feedback we've left internally relevant to this:
Extraction fultons should be trackable somehow. Maybe a console that prints out paper "Syndicate fulton detected near : Epistemics " whenever a traitor uses it, and the extraction time is 1+ minutes. I'm torn on if the item being fultoned should be reported.

Also yes, the items go to the syndie vault. Perhaps a trade can be set up.

@Avalon-Proto
Copy link
Contributor

From what I can tell, the way to get these items back is planned. I think Deltanedas is adding a ransom system to the cargo order computer, where you will be able to buy back kidnapped heads and stolen equipment. So its not like its gone forever and irrecoverable

@deltanedas
Copy link
Member Author

ransom is for buying back people since being round removed isnt fun, for items it doesnt make sense, why would cybersun want to RE a hypospray but also be happy to sell it back for 5k, at which point another traitor goes to ats to pick it up and automatically have a free objective

also doesnt mean a lot when ce loses his boots for 10 minutes then gets it back, the boots dont care and ce wont care too much, compared to a person being kidnapped

@DieselMohawk
Copy link
Contributor

In the current state, it's going to be a HORRIBLE gameplay loop for detective, a lot of the time detective investigations will circle down on someone and they will be searched, but imagine the same gameplay loop but a MINUTE after every crime the item just gets sent to hell. Now people will need to arrested on NO EVIDENCE just to recover the item before the syndicate fucks off into maints and deletes the stolen item.

@DieselMohawk
Copy link
Contributor

More potential issues:

1: Changing the name of the nearest station beacon then changing it back.
2: Starting the fulton process so it'll say it's somewhere, then just moving it somewhere else, such as space. (Assuming it can be moved like normal fultons)
3: Being able to start the fulton process anywhere, even when off station grid where security can't even respond
4: Starting the fulton process then walling it off (Minecraft style), which requires tools that security will NEVER have.

@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 13, 2025

More potential issues:

a lot of these are syndicate gaming activities. if they are acting quickly and running around, theres gonna be forensics to track the gamer down. forensics do need to be more robust but thats another story

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 15, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants