Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragons despawn with 10 mins between rifts, gib on death, etc #3017

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Dragons despawn with 10 mins between rifts, gib on death, etc #3017

wants to merge 13 commits into from
+46 −8

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Feb 19, 2025 •
edited
Loading

About the PR

dragons no longer despawn

Why / Balance

dragons forced to rift instead of plan out or rp is mid. Not Direction approved.

Technical details

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Dragons despawn in 10 minutes with no rifts, up from 5
  • tweak: Dragons now are gibbed upon being removed for having no rifts; not deleted. Collect the corpses!
  • tweak: Dragons are only weakened for 1 minute after rift destruction, not 2

@Lyndomen Lyndomen requested review from a team as code owners February 19, 2025 21:26
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files and removed size/S 16-63 lines labels Feb 19, 2025
@Lyndomen
Copy link
Contributor Author

idk maybe this is rat king 2, but the timer kinda sucks and this isnt even a mald pr

@ThataKat
Copy link
Contributor

Direction review real 24 hours

@Lyndomen
Update MinorAntagonists.xml
d1a59a9 
Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
@github-actions github-actions bot added the size/S 16-63 lines label Feb 19, 2025
@dvir001
Copy link
Contributor

dvir001 commented Feb 19, 2025

I had a Dragon eat me before, then fly into space and despawn, kinda ass.

@Lyndomen
Copy link
Contributor Author

I had a Dragon eat me before, then fly into space and despawn, kinda ass.

Another ez bugfix

deltanedas
deltanedas requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use /* */ to comment it out

@deltanedas
Copy link
Member

you cant comment in guidebooks use /**/ for the c#

@ThataKat
Copy link
Contributor

Tweaks are underway I think, probably going to wait till tomorrow for those to happen and be discussed before final decision

@deltanedas
use multiline comment
6f7f658 
Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
@deltanedas
guidebooks cant have comments
294b3ef 
Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
deltanedas
deltanedas previously approved these changes Feb 22, 2025
View reviewed changes
@deltanedas deltanedas requested a review from a team February 22, 2025 01:36
@github-actions github-actions bot added size/XS Under 16 lines and removed size/S 16-63 lines labels Feb 22, 2025
@Lyndomen
Copy link
Contributor Author

Lyndomen commented Feb 22, 2025 via email

@deltanedas
Copy link
Member

add a popup for it at 5 or 7 or something too so its not untelegraphed instant deletion
and change it to kill or gib instead of delete because deleting people is obviously bad

@github-actions github-actions bot added size/S 16-63 lines and removed size/XS Under 16 lines labels Feb 22, 2025
@Lyndomen Lyndomen changed the title Dragons no longer despawn Dragons despawn with 10 mins between rifts, gib on death, etc Feb 22, 2025
@Lyndomen Lyndomen requested a review from deltanedas February 22, 2025 20:38
@Lyndomen
Copy link
Contributor Author

image

@Lyndomen
Copy link
Contributor Author

idk how shitcode my changes are but im also gonna upstream this once its less shit

@ThataKat
Copy link
Contributor

Yes direction approved (I was fiddling with the review system but I don't wanna break anything)

deltanedas
deltanedas requested changes Feb 23, 2025
View reviewed changes
@Lyndomen Lyndomen requested a review from deltanedas February 23, 2025 03:04
deltanedas
deltanedas requested changes Feb 23, 2025
View reviewed changes
Content.Server/Dragon/DragonSystem.cs
Roar(uid, comp);
_damageable.TryChangeDamage(uid, comp.DeathDamage,true,true); // gib time
}
// End DeltaV Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lyndomen @ThataKat @dvir001 @deltanedas