Refactor tests pa #336
Merged
Refactor tests pa #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panosatha
commented
Jan 19, 2024
•
panosatha
commented
- Small updates in the benefits code to avoid repetative code and add documentation
- Refactoring of tests for benefits by implementing unit tests for each method
…into refactor_tests_PA
…into refactor_tests_PA
Santonia27
reviewed
May 8, 2024
| ------- | ||
| IBenefit | ||
| a Benefit object | ||
| """ | ||
|
|
||
| obj = Benefit() | ||
| with open(filepath, mode="rb") as fp: | ||
| toml = tomli.load(fp) | ||
| obj.attrs = BenefitModel.parse_obj(toml) |
There was a problem hiding this comment.
parse_object throws an error/warning The method "parse_obj" in class "BaseModel" is deprecated
The parse_obj method is deprecated; use model_validate instead
Do we want to update that?
There was a problem hiding this comment.
Same in line 607 with "dict"
There was a problem hiding this comment.
I think that is the case for all our objects currently after a change in the pydantic version. So this should be solved in a seperate PR.
Santonia27
reviewed
May 8, 2024
There was a problem hiding this comment.
Should there be a small test for "def save(self, filepath: Union[str, os.PathLike]): ?
Santonia27
approved these changes
May 8, 2024
dladrichem
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.