using z-value in floodwall from shp file #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
panosatha
reviewed
Apr 25, 2024
panosatha
reviewed
Apr 25, 2024
panosatha
reviewed
Apr 25, 2024
panosatha
approved these changes
Apr 29, 2024
panosatha
deleted the
425-allow-dike-shape-file-import-with-multiple-dikes-and-heights
branch
dumontgoulart
added a commit
that referenced
this pull request
May 15, 2024
* Fix publisher * Refactor of the save/edit/delete enz. functions for all tabs (#367) * Fix dbs classes * Fix rebase issues * Add lock_count and start unit testing * Add tests * Temp fixes * Add test template * Add unit tests * Fixed deleting function * Fix scenarios in dbs controller * Remove tests for other branch * Fix scenario logging * Fix ruff and black * Fix spellcheck * Fix comments and remove locking * Make check_higher_level_usage function public * Add rerunning validators * Remove lock count (#415) * Added a section on socio-economic projections (#416) * Added a section on socio-economic projections * Added a section on socio-economic projections * fixed a typo in the index.qmd so the spell test passes * Add validators (#417) * Add validators * Fix black * Fix escaped backslash * Fix errorhandling historic events * Fix errorhandling historic events nad fix black * Setup wiki docs * changed how the Hazard object is initialized to avoid creating the different event object in risk run before the scenario is run (#391) * Docs measures building level (#426) * Added content on building-level measures and modified the main landing page for the measures * entered content for building-level measures and edited the index file for the measures. also fixed a typo * fix error on startup of event popup window * Update docs.yml (#428) * using z-value in floodwall from shp file (#427) * using z-value in floodwall from shp file and convertin MultiLineString to LineString * black * addressing review comments * address review comment: convert also z-values from shape file * fixed unit conversion * black * include logging statement when height from shape file cannot be read * black * include positive logging info when height from shape is used * update raise by for datum ref tests (#431) * Update pyproject.toml (#434) * Update pyproject.toml * fix , * Fix/docs landing page (#437) * fix landing page * Fix merge conflict * Fix typo * Test youtube video (#438) --------- Co-authored-by: Daley Adrichem <Daley.Adrichem@deltares.nl> Co-authored-by: dladrichem <136334482+dladrichem@users.noreply.github.com> Co-authored-by: kathrynroscoe <79269966+kathrynroscoe@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com> Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: Santonia27 <145111392+Santonia27@users.noreply.github.com> Co-authored-by: GundulaW <74292006+GundulaW@users.noreply.github.com> Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also converting possible MultiLineStrings to LineStrings to work with hydromt-sfincs
At the moment, this requires the shape file to have a z-column. Otherwise, the uniform elevation value from the GUI will be taken. I am trying to make this neater in the GUI by allowing the user to specify whether a unifrom value should be used for all floodwalls or which column should eb taken from the shape file. But I have not succeeded yet. This will be a future PR in the GUI