Updates in site.toml to clear not-used attributes and update some vairables #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
10 tasks
GundulaW
reviewed
Jun 17, 2024
…into 422-site-toml-issues
…into 422-site-toml-issues
dumontgoulart
added a commit
that referenced
this pull request
Jul 9, 2024
* take most of the env creation script from frontend and put it in the … (#467) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * added temporary event name for plotting rainfall and river (#470) * Move env creation to backend (#468) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * fix bug in env creation * black * pre-commit version and fiat adapter test not skipped anymore (#463) * updated pre-commit version * updated svn repo so this test can be run now * return periods test is not skipped anymore with fiat_toolbox updates * changed cht_observation to git repo install * chore: close all loggers & handlers in database fixture setup and teardown * fix: Output more info if incompatible river coordinates in SFINCS adapter and sitetoml * add reset() to dbs_controller.py * reset database in conftest.py * black * fix versions of formatting tools --------- Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> * Add self check to hazard run check (#471) * Add self check to hazard run check * Fix black * Updates in site.toml to clear not-used attributes and update some vairables (#462) * removed unused attributes from site toml * small update in lint * made observation points non mandatory * changed site attribute obs_station to tide_gauge and removed unused attributes * changed the flooding_threshold attribute to belong to a flood_frequency variable * added default value for flood frequency flooding threshold * when no river is present template discharge is used for now * added source option to tide_gauge site attribute * small correction in docstring * changed slr.scenarios in site.toml and made them not mandatory * offshore model and cyclone tracks not mandatory anymore * small updates * naming change * make sure that the workflow does not break when there is nothing to plot * todo on api for aggregation * revert rename (#474) * Fix logging and tests (#475) * fix api output fixture and tests * return -> yield in all fixtures * return -> yield in all fixtures * fix scenario.run() tests * add logging class and implement in codebase * bugfix logger contextmanager * improve test logging * fix bug in create_roads * Add attribute check to adapter logger * Config changes (#476) * database path updates * Update config getters to return Paths where needed * Update lint.yml * Update lint.yml --------- Co-authored-by: GundulaW <gundulawinter@gmail.com> * Split mandatory and optional metrics (#477) --------- Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com> Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: dladrichem <136334482+dladrichem@users.noreply.github.com> Co-authored-by: Daley Adrichem <daley.adrichem@deltares.nl> Co-authored-by: GundulaW <gundulawinter@gmail.com>
dumontgoulart
added a commit
that referenced
this pull request
Jul 9, 2024
* take most of the env creation script from frontend and put it in the … (#467) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * added temporary event name for plotting rainfall and river (#470) * Move env creation to backend (#468) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * fix bug in env creation * black * pre-commit version and fiat adapter test not skipped anymore (#463) * updated pre-commit version * updated svn repo so this test can be run now * return periods test is not skipped anymore with fiat_toolbox updates * changed cht_observation to git repo install * chore: close all loggers & handlers in database fixture setup and teardown * fix: Output more info if incompatible river coordinates in SFINCS adapter and sitetoml * add reset() to dbs_controller.py * reset database in conftest.py * black * fix versions of formatting tools --------- Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> * Add self check to hazard run check (#471) * Add self check to hazard run check * Fix black * Updates in site.toml to clear not-used attributes and update some vairables (#462) * removed unused attributes from site toml * small update in lint * made observation points non mandatory * changed site attribute obs_station to tide_gauge and removed unused attributes * changed the flooding_threshold attribute to belong to a flood_frequency variable * added default value for flood frequency flooding threshold * when no river is present template discharge is used for now * added source option to tide_gauge site attribute * small correction in docstring * changed slr.scenarios in site.toml and made them not mandatory * offshore model and cyclone tracks not mandatory anymore * small updates * naming change * make sure that the workflow does not break when there is nothing to plot * todo on api for aggregation * revert rename (#474) * Fix logging and tests (#475) * fix api output fixture and tests * return -> yield in all fixtures * return -> yield in all fixtures * fix scenario.run() tests * add logging class and implement in codebase * bugfix logger contextmanager * improve test logging * fix bug in create_roads * Add attribute check to adapter logger * Config changes (#476) * database path updates * Update config getters to return Paths where needed * Update lint.yml * Update lint.yml --------- Co-authored-by: GundulaW <gundulawinter@gmail.com> * Split mandatory and optional metrics (#477) --------- Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com> Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: dladrichem <136334482+dladrichem@users.noreply.github.com> Co-authored-by: Daley Adrichem <daley.adrichem@deltares.nl> Co-authored-by: GundulaW <gundulawinter@gmail.com>
dumontgoulart
added a commit
that referenced
this pull request
Jul 11, 2024
* take most of the env creation script from frontend and put it in the … (#467) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * added temporary event name for plotting rainfall and river (#470) * Move env creation to backend (#468) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * fix bug in env creation * black * pre-commit version and fiat adapter test not skipped anymore (#463) * updated pre-commit version * updated svn repo so this test can be run now * return periods test is not skipped anymore with fiat_toolbox updates * changed cht_observation to git repo install * chore: close all loggers & handlers in database fixture setup and teardown * fix: Output more info if incompatible river coordinates in SFINCS adapter and sitetoml * add reset() to dbs_controller.py * reset database in conftest.py * black * fix versions of formatting tools --------- Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> * Add self check to hazard run check (#471) * Add self check to hazard run check * Fix black * Updates in site.toml to clear not-used attributes and update some vairables (#462) * removed unused attributes from site toml * small update in lint * made observation points non mandatory * changed site attribute obs_station to tide_gauge and removed unused attributes * changed the flooding_threshold attribute to belong to a flood_frequency variable * added default value for flood frequency flooding threshold * when no river is present template discharge is used for now * added source option to tide_gauge site attribute * small correction in docstring * changed slr.scenarios in site.toml and made them not mandatory * offshore model and cyclone tracks not mandatory anymore * small updates * naming change * make sure that the workflow does not break when there is nothing to plot * todo on api for aggregation * revert rename (#474) * Fix logging and tests (#475) * fix api output fixture and tests * return -> yield in all fixtures * return -> yield in all fixtures * fix scenario.run() tests * add logging class and implement in codebase * bugfix logger contextmanager * improve test logging * fix bug in create_roads * Add attribute check to adapter logger * Config changes (#476) * database path updates * Update config getters to return Paths where needed * Update lint.yml * Update lint.yml --------- Co-authored-by: GundulaW <gundulawinter@gmail.com> * Split mandatory and optional metrics (#477) --------- Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com> Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: dladrichem <136334482+dladrichem@users.noreply.github.com> Co-authored-by: Daley Adrichem <daley.adrichem@deltares.nl> Co-authored-by: GundulaW <gundulawinter@gmail.com>
dumontgoulart
added a commit
that referenced
this pull request
Jul 11, 2024
* take most of the env creation script from frontend and put it in the … (#467) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * added temporary event name for plotting rainfall and river (#470) * Move env creation to backend (#468) * take most of the env creation script from frontend and put it in the backend * move env_docs.yml to the docs dir * update readme * fix bug in env creation * black * pre-commit version and fiat adapter test not skipped anymore (#463) * updated pre-commit version * updated svn repo so this test can be run now * return periods test is not skipped anymore with fiat_toolbox updates * changed cht_observation to git repo install * chore: close all loggers & handlers in database fixture setup and teardown * fix: Output more info if incompatible river coordinates in SFINCS adapter and sitetoml * add reset() to dbs_controller.py * reset database in conftest.py * black * fix versions of formatting tools --------- Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> * Add self check to hazard run check (#471) * Add self check to hazard run check * Fix black * Updates in site.toml to clear not-used attributes and update some vairables (#462) * removed unused attributes from site toml * small update in lint * made observation points non mandatory * changed site attribute obs_station to tide_gauge and removed unused attributes * changed the flooding_threshold attribute to belong to a flood_frequency variable * added default value for flood frequency flooding threshold * when no river is present template discharge is used for now * added source option to tide_gauge site attribute * small correction in docstring * changed slr.scenarios in site.toml and made them not mandatory * offshore model and cyclone tracks not mandatory anymore * small updates * naming change * make sure that the workflow does not break when there is nothing to plot * todo on api for aggregation * revert rename (#474) * Fix logging and tests (#475) * fix api output fixture and tests * return -> yield in all fixtures * return -> yield in all fixtures * fix scenario.run() tests * add logging class and implement in codebase * bugfix logger contextmanager * improve test logging * fix bug in create_roads * Add attribute check to adapter logger * Config changes (#476) * database path updates * Update config getters to return Paths where needed * Update lint.yml * Update lint.yml --------- Co-authored-by: GundulaW <gundulawinter@gmail.com> * Split mandatory and optional metrics (#477) --------- Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com> Co-authored-by: LuukBlom <luuk.blom@deltares.nl> Co-authored-by: dladrichem <136334482+dladrichem@users.noreply.github.com> Co-authored-by: Daley Adrichem <daley.adrichem@deltares.nl> Co-authored-by: GundulaW <gundulawinter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to avoid having optional configuration as mandatory in the site.toml: