made sure that the optional config metric toml is not mandatory #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dladrichem
approved these changes
Jul 11, 2024
…into optional_metric_bug
dumontgoulart
added a commit
that referenced
this pull request
Jul 18, 2024
* add dask to dependencies + limit to the last version that is compatible with pandas 1.x (#483) * change branch in hydromt_sfincs * add dask to dependencies + limit to the last version that is compatible with pandas 1.x * made sure that the optional config metric toml is not mandatory (#481) * made sure that the option config metric toml is not mandatory * updated types of metric configs * added an error for when mandatory config not available * made infographic creation not mandatory (#491) * made infographic creation not mandatory * review updates * added a check to see if the risk infographic config is available and if not to produce an error (#493) --------- Co-authored-by: LuukBlom <153174893+LuukBlom@users.noreply.github.com> Co-authored-by: Panos Athanasiou <38324721+panosatha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.