Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend implementation for issue #431 in FloodAdapt-GUI #557

Merged
merged 2 commits into from
Oct 11, 2024
Merged

backend implementation for issue #431 in FloodAdapt-GUI #557

merged 2 commits into from
Oct 11, 2024

Conversation

LuukBlom
Copy link
Contributor

@LuukBlom LuukBlom requested a review from Santonia27 October 11, 2024 13:19
@LuukBlom LuukBlom self-assigned this Oct 11, 2024
GundulaW
GundulaW approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@GundulaW GundulaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I also checked the frontend, bug is resolved and all rainfall shapes show up.

@GundulaW GundulaW merged commit 2b6ac48 into main Oct 11, 2024
2 of 4 checks passed
@GundulaW GundulaW deleted the 431-rainfall-in-the-synthetic-event-front-end-doesnt-let-you-specify-a-shape-or-constant-value branch October 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GundulaW GundulaW GundulaW approved these changes

@Santonia27 Santonia27 Awaiting requested review from Santonia27

Assignees

@LuukBlom LuukBlom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuukBlom @GundulaW