Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing file location instead of geodataframe to get_area_labels #30

Closed
Erik-Geo opened this issue Aug 28, 2024 · 1 comment
Closed

Allow passing file location instead of geodataframe to get_area_labels #30

Erik-Geo opened this issue Aug 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Erik-Geo
Copy link
Collaborator

The get_area_labels method currently requires the label polygon file to already be parsed to a geodataframe. This is not consistent with other methods that require geometry or raster data, which allow the user to pass a file location rather than a geodataframe (for geometries) or Xarray.DataArray (for rasters)

Affected are:

collection.get_area_labels
header.get_area_labels
spatial.find_area_labels
@Erik-Geo Erik-Geo added the enhancement New feature or request label Aug 28, 2024
@Erik-Geo
Copy link
Collaborator Author

Erik-Geo commented Sep 2, 2024

Added in commit 3df2b9a

Erik-Geo added a commit that referenced this issue Sep 2, 2024
@Erik-Geo
Allow passing file location instead of gdf to get_area_labels methods (…
3df2b9a 
…#30)
@Erik-Geo Erik-Geo closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Erik-Geo