Feature/dei 24 tests for parser #7
Conversation
| IModelData: _description_ | ||
| """ | ||
| """Parse the Yaml input file into a data object""" | ||
| print('contennts', contents) |
There was a problem hiding this comment.
print statement can be removed
There was a problem hiding this comment.
Do we need to add a description for the parameter ?
There was a problem hiding this comment.
check, added it. Have now on multiple locations a default for the description.
print statement removed
|
|
||
| # Assert | ||
| expected_message = "Missing element multipliers" | ||
| assert exception_raised.args[0] == expected_message |
There was a problem hiding this comment.
Do we also want a test for invalid data in the multipliers -> like "multipliers": "abc", or "multipliers": [0.0, "abc"]
Do we need to check for duplicate keys ?
There was a problem hiding this comment.
dict can never have duplicate keys, so this will never occurs. When yaml is loaded this already filtered out. Don't think we need to check that.
Added a Valueerror when the multipliers are not a list of floats.
No description provided.