Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If old external forcing file references a pli file, the accompanying .tim/.cmp should also be read and stored #501

Open
priscavdsluis opened this issue Mar 31, 2023 · 0 comments
Labels
priority: high type: bug Something isn't working type: compatibility Changes needed to be compatible with the computational core

Comments

@priscavdsluis
Copy link
Contributor

          I will create a new issue for the following point (as discussed with team):

The filename value on a filename=... line should maybe ? be of type Union[PolyFile, TimModel, DiskOnlyFileModel].
As such, we hope to recursively read/store if a .pli file is given, but all other file types are only stored by filename, and copied as-is by the existing functionality in DiskOnlyFileModel. The idea behind this is that we need to also read/store for each .pli file the accompanying .tim or .cmp file. Further design discussion is still needed for this.

Originally posted by @priscavdsluis in #369 (comment)

@priscavdsluis priscavdsluis changed the title If old external forcing file references a pli file, the accompanying .tim/.cmp should are be read and stored If old external forcing file references a pli file, the accompanying .tim/.cmp should also be read and stored Mar 31, 2023
@priscavdsluis priscavdsluis added type: bug Something isn't working type: compatibility Changes needed to be compatible with the computational core priority: high labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: bug Something isn't working type: compatibility Changes needed to be compatible with the computational core
Projects
Status: To do
Development

No branches or pull requests

1 participant