-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When there are unknown keywords in the mdu, an error should be given instead of them being silently dropped. #622
Comments
…ow also written, but in random order, causing a failing file comparison. (#622)
When you encounter unknown keywords. Please give the following warning: Unknown keywords are detected (in section of MDU file): list of unknown keywords. In case of unknown keywords are allowed (#630 - keywords), then the keywords will be kept in memory. (Note that these unknown keywords have no validation). Else the keywords will be dropped. |
I have updated the changes in #632.
When I set the configuration to allow unknown keywords I get the following output: When I set the configuration to not allow unknown keywords I get the following output: When the configuration is set to not allow unknown keywords, unknown keywords will throw an exception as before on setting with the model, e.g. Developer opinion@MRVermeulenDeltares: Requirements from refinement
|
Is your feature request related to a problem? Please describe.
In #568 a request was made to give the user feedback on unsupported keywords instead of silently dropping them. Since the issue also requested other changes we decided to move this specific request into a separate issue.
Describe the solution you'd like
When we encounter an unknown mdu keyword, we should give an error to the user instead of silently dropping the keyword.
The text was updated successfully, but these errors were encountered: