Support crs file for observation cross sections #289
Conversation
Added testcase for the General section.
…ons' of https://github.com/Deltares/HYDROLIB-core into feature/159_Support_CrsFile_for_observation_cross_sections # Conflicts: # hydrolib/core/io/obscrosssection/models.py # tests/io/test_obscrosssection.py
Added an additional validator to the ObservationPointCrossSection class.
…ons' of https://github.com/Deltares/HYDROLIB-core into feature/159_Support_CrsFile_for_observation_cross_sections # Conflicts: # hydrolib/core/io/obscrosssection/models.py # tests/io/test_obscrosssection.py
…nates match the expecter number of coordinates.
…ross section model.
This reverts commit 2fda2ef.
…ons' of https://github.com/Deltares/HYDROLIB-core into feature/159_Support_CrsFile_for_observation_cross_sections # Conflicts: # hydrolib/core/io/ini/util.py
| """ | ||
|
|
||
| general: ObservationPointCrossSectionGeneral = ObservationPointCrossSectionGeneral() | ||
| crosssections: List[ObservationPointCrossSection] = [] |
There was a problem hiding this comment.
The agreed convention for these lists is to call the field the singular form of the object in the list, so in this case:
| crosssections: List[ObservationPointCrossSection] = [] | |
| observationpointcrosssection: List[ObservationPointCrossSection] = [] |
(but it should be observationcrosssection)
I don't remember why exactly, but I will ask @arthurvd or @BeardedPlatypus when they get back.
There was a specific reason for it.
There was a problem hiding this comment.
Look really nice and well documented!
I do have some remarks. Please take a look and let me know what you think.
There are also 2 code smells, The one about the complexicity ties together with one comment I wrote and the other I think we can ignore, since it has to do with the way we use pydantic validation.
tim-vd-aardweg
changed the title
…instead of validating all possible invalid situations.
…rvationCrossSection class.
…of coordinates required.
|
Kudos, SonarCloud Quality Gate passed!
|
priscavdsluis
deleted the
feature/159_Support_CrsFile_for_observation_cross_sections
branch
No description provided.