-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
272#: Refactor get_location_specification_root_validator #347
272#: Refactor get_location_specification_root_validator #347
Conversation
…cationValidationFieldNames attributes.
…tion-root-validator
… when `validate_num_coordinates` = False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review OK!
…tion-root-validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @priscavdsluis, can you also check my few small comments?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Edited the existing
get_location_specification_rootvalidator
and removed theget_number_of_coordinates_validator
. This one is merged in the new validator.The validator is now configurable with a configuration class and the field names are also adjustable with a separate class.
The validator is made up of local functions.
Normally, local functions are not really nice I think, but because we need to have all the information, I think it is better to keep them private and local. This makes the "body" of the actual validation method more tidy and clean.
The validation method now has a more step-wise implementation.