Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/316 forcing vectorquantities #381

Merged
merged 9 commits into from
Oct 25, 2022

Commits on Oct 19, 2022

  1. autoformat: isort & black

    arthurvd committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d20c9de View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    44a384c View commit details
    Browse the repository at this point in the history
  2. 316: add full support for vector quantities in T3D and Timeseries bou…

    …ndaries
    
    * VectorQuantityUnitPairs object represents both the "vector=" headerline and *all* coupled vector elements's QuantityUnitPairs below.
    * `ScalarOrVectorQUP = Union[QuantityUnitPair, VectorQuantityUnitPairs]` for convenience.
    * same approach taken as was already done for the original QuantityUnitPair creation and the vertPositionIndex modification, namely via a root_validator (pre=True) in both TimeSeries and T3D.
    * the actual root_validator `_validate_vectordefinition_and_update_quantityunitpairs()` has been placed in `class ForcingBase` to share all code.
    * unit tests added, both reading from file and constructing in memory.
    arthurvd committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    31396b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ae9ac2 View commit details
    Browse the repository at this point in the history
  4. Remove unused variable

    arthurvd committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2ec0c9e View commit details
    Browse the repository at this point in the history
  5. Fix some code smells

    arthurvd committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    73e6cce View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Configuration menu
    Copy the full SHA
    9021796 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba2cb30 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Major cleanup+review followup vector quantities in bc.

    * VectorQuantityUnitPairs now has Config, validate_assignment = True to re-run validators when its children quantityunitpair list gets re-assigned.
    * Some extra vector validation is now directly in VectorQuantityUnitPairs, when creating these objects from scratch (as opposed to reading from file)
    * the original vector validator that used to be in ForcingBase was now moved to dedicated class VectorQUPValidation, used by both TimeSeries and T3D.
    * This new class VectorQUPValidation also has separate subroutine for validating number of vector elements, again useful when constructing TimeSeries or T3D from scratch (as opposed to reading from file)
    * some extra unit tests asserting errors when quantity names are wrong or wrong amount.
    * test_bc, cleanup: time unit "m" -> parameter.
    arthurvd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    c47dad0 View commit details
    Browse the repository at this point in the history