Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

474: Add support for 3D z-sigma settings in MDU #476

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

arthurvd
Copy link
Member

Fixes #474.

Copy link
Contributor

@priscavdsluis priscavdsluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurvd, changes look good.
I added a comment in the reference file. Because the test is failing for MacOS and Ubuntu.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arthurvd arthurvd dismissed priscavdsluis’s stale review March 28, 2023 18:44

All checks have passed, after I merged main into this branch (where main now included the OS path style changes from #339).

@arthurvd
Copy link
Member Author

Now ready for review approval: I merged main, which now includes #339 changes, so the last checks on Windows are now also green again.

@priscavdsluis priscavdsluis merged commit fe40cbd into main Mar 29, 2023
@priscavdsluis priscavdsluis deleted the feat/474_z-sigma-mdu branch March 29, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z-sigma layers not supported by FMModel
2 participants