Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement 2d boundary #152

Closed
6 of 7 tasks
xldeltares opened this issue Mar 13, 2023 · 2 comments · Fixed by #162
Closed
6 of 7 tasks

implement 2d boundary #152

xldeltares opened this issue Mar 13, 2023 · 2 comments · Fixed by #162
Assignees
@xldeltares
Labels
HydroMT issue related to hydromt_delft3dfm plugin

Comments

@xldeltares
Copy link
Collaborator

xldeltares commented Mar 13, 2023 •
edited
Loading

Functional requirement:

  • spatially-uniform constant boundary using boundaries_fn and boundary_value (default), --> But this DOES NOT open in GUI. --> by writing into a timeseries with start stop time the same as model time, this can be open in GUI.
  • spatially-uniform time-series boundary read from boundaries_fn and boundaries_timesries_fn (TODO Not Implemented),
  • spatially-varying time-series boundary read from boundaries_geodataset_fn (TODO Not Implemented).

Remarks:

  • Hydrolib-core polyfile parser was not applicable for boundary type pli file. Bug reported here: Polyfile parser does not parse 2D boundary type of pli file correctly.  HYDROLIB-core#467 --> It turns out the point labels exported by GUI is not used by the kernel, therefore no need to support this. See comment in the issue.
  • Above also means we cannot use hydrolib-core to correctly read it back. --> Because of the above, this is no longer valid, hydrolib-core can read it back.
  • Write_forcings does not yet support complete writing of boundary, meteo and laterals, needs improvement. New feature requested here: Support write all type of forcings in write_forcing function #153 --> half fixed for 1d and 2d boundary
  • Need more inverstigation on how to read everything back properly.
@xldeltares xldeltares added the HydroMT issue related to hydromt_delft3dfm plugin label Mar 13, 2023
@xldeltares xldeltares self-assigned this Mar 13, 2023
@xldeltares
Copy link
Collaborator Author

First option is implemented.

xldeltares added a commit that referenced this issue Mar 20, 2023
@xldeltares
#152 implement setup_2dboundary, update setup_1dboundary
5eba722 
supports:
spatial uniform constant boundary

does not support yet:
spatial uniform timeseries boundary
spatial varying timeseries boundary
xldeltares added a commit that referenced this issue Mar 20, 2023
@xldeltares
#152 add tolerance to setup_2dboundary
9a3b0d4
xldeltares added a commit that referenced this issue Mar 20, 2023
@xldeltares
#152 fix quantity
519f7ac
xldeltares added a commit that referenced this issue Mar 21, 2023
@xldeltares
#152 change time interpolation method to Block-From
0494a12
@xldeltares xldeltares linked a pull request Jun 22, 2023 that will close this issue
Hydromt 152 implement 2d boundary #162
Merged
@veenstrajelmer
Copy link
Contributor

This issue will be closed as won't do since hydromt_delft3dfm moved to a separate repos.

@veenstrajelmer veenstrajelmer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xldeltares xldeltares

Labels
HydroMT issue related to hydromt_delft3dfm plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hydromt 152 implement 2d boundary Deltares/HYDROLIB
2 participants
@veenstrajelmer @xldeltares