Feature/gridedit 777 casulli refinement #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacarniato
requested changes
Jan 22, 2024
…7_casulli_refinement
lucacarniato
approved these changes
Jan 30, 2024
| /// | ||
| /// Returns 0 when the node is at the start of the edge, 1 when it is at the end | ||
| /// and the null value when the edge is not connected to the node. | ||
| UInt IsStartOrEnd(const UInt edgeId, const UInt nodeId) const; |
There was a problem hiding this comment.
in entities there is a function OtherNodeOfEdge, shall we move OtherNodeOfEdge also in mesh2d class?
| /// @brief Find the id of the element that is common to both edges. | ||
| /// | ||
| /// If no such element can be found then the null value will be returned. | ||
| UInt FindCommonElement(const UInt edge1, const UInt edge2) const; |
There was a problem hiding this comment.
FindCommonFace, for keeping the implementation consistent
There was a problem hiding this comment.
Please add doc for the parameters of all methods.
Comment on lines
86
to
89
| static void ConnectNewNodes(Mesh2D& mesh, const std::vector<EdgeNodes>& newNodes, const UInt numNodes, const UInt numEdges, const UInt numFaces, std::vector<NodeMask>& nodeMask); | ||
|
|
||
| /// @brief Add newly generated nodes to the newNodes list. | ||
| static void StoreNewNode(const Mesh2D& mesh, const UInt nodeId, const UInt edge1Index, const UInt edge2Index, const UInt newNodeId, std::vector<EdgeNodes>& newNodes); |
There was a problem hiding this comment.
It would be nice to have each parameter on a separate line for better readability (Also in the source file).
| @@ -160,6 +160,11 @@ namespace meshkernel | |||
| /// @return If the face is on boundary | |||
| [[nodiscard]] bool IsFaceOnBoundary(UInt face) const; | |||
|
|
|||
| /// @brief Get the local index of the node belong to a face. | |||
| void meshkernel::CasulliRefinement::Compute(Mesh2D& mesh) | ||
| { | ||
| Polygons emptyPolygon; | ||
| Compute(mesh, emptyPolygon); |
There was a problem hiding this comment.
Can pass a Polygons constructor here
|
|
||
| std::vector<meshkernel::CasulliRefinement::NodeMask> meshkernel::CasulliRefinement::InitialiseNodeMask(const Mesh2D& mesh, const Polygons& polygon) | ||
| { | ||
| std::vector<NodeMask> nodeMask(10 * mesh.GetNumNodes(), NodeMask::Unassigned); |
Comment on lines
+45
to
+46
| UInt node1 = mesh.m_edges[i].first; | ||
| UInt node2 = mesh.m_edges[i].second; |
There was a problem hiding this comment.
Can us e structured binding. Either way please make const.
Comment on lines
+75
to
+76
| UInt elementId = mesh.m_edgesFaces[edge1][0]; | ||
| UInt nodeCount = mesh.m_numFacesNodes[elementId]; |
ahmad-el-sayed
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.