Feature/gridedit 902 revalidating curvi tests #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct rows forNumM and columns for NumN Change CurvilinearGridNodeIndices Fix CurvilinearGrid class Fix CurvilinearGridLineAttractionRepulsion
Correct CurvilinearGridSmoothing
Fix api tests after reordering of faces
…MakeCurvilinearGrid
BillSenior
reviewed
Mar 11, 2024
Comment on lines
+103
to
+106
| CurvilinearGridNodeIndices currentNode{ | ||
| m_lines[0].IsMGridLine() ? i : node.m_n, | ||
| m_lines[0].IsMGridLine() ? node.m_m : i, | ||
| }; |
There was a problem hiding this comment.
Is it correct that the test is
m_lines[0].Is**M**GridLine()
For both the m and n direcitons?
BillSenior
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.