Feature/gridedit 934 undo for curvilinear #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases rather than base class
…moved during the administration
Changed name of function from GetNumActiveNodes/Edges to GetNumValidNodes/Edges Fixed windows compilation error.
Added extra members to Mesh1/2D, for the number of valid nodes and edges
…re set to invalid
Updated error message when index is out of range.
…fo in failure in TC
Getting unit tests for undo in curvilinear grids working
…ithub.com/Deltares/MeshKernel into feature/GRIDEDIT-934_undo_for_curvilinear
lucacarniato
approved these changes
Apr 4, 2024
libs/MeshKernel/include/MeshKernel/CurvilinearGrid/AddGridLineUndoAction.hpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/include/MeshKernel/CurvilinearGrid/CurvilinearGrid.hpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/include/MeshKernel/CurvilinearGrid/CurvilinearGrid.hpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/include/MeshKernel/CurvilinearGrid/CurvilinearGrid.hpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridLineShift.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridRefinementUndoAction.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/ResetCurvilinearNodeAction.cpp
Outdated
Show resolved
Hide resolved
| grid->GetNode(ny, i).y = grid->GetNode(ny - 1, i).y + deltaY; | ||
| } | ||
|
|
||
| // // For left but bottom |
|
|
||
| grid->ComputeGridNodeTypes(); | ||
|
|
||
| // undoActions.Undo(); // |
Fixed bug when doing undo for insert face
…ithub.com/Deltares/MeshKernel into feature/GRIDEDIT-934_undo_for_curvilinear
lucacarniato
approved these changes
Apr 18, 2024
| #pragma once | ||
|
|
||
| #include <memory> | ||
| #include <utility> |
There was a problem hiding this comment.
utility and vector not needed
| void CommitAction(const ResetCurvilinearNodeAction& undoAction); | ||
|
|
||
| /// @brief Prints the node and edge connectivity to the output stream in a form that can be read by Octave/Matlab | ||
| void printGraph(std::ostream& out = std::cout); |
There was a problem hiding this comment.
This function should be removed
| @@ -53,6 +53,20 @@ namespace meshkernel | |||
| /// @brief Overloads equality with another CurvilinearGridNodeIndices | |||
| bool operator==(const CurvilinearGridNodeIndices& rhs) const = default; | |||
|
|
|||
| CurvilinearGridNodeIndices& operator+=(const CurvilinearGridNodeIndices& val) | |||
There was a problem hiding this comment.
Would make sense to check if the addition or subtraction goes out of bounds here?
| UInt FullNumN() const { return static_cast<UInt>(m_gridNodes.rows()); } | ||
|
|
||
| /// @brief Restore grid to state before grid line was added | ||
| void RestoreAction(const AddGridLineUndoAction& undoAction); |
There was a problem hiding this comment.
create an UndoAction folder where to put all actions, like you did for mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.