Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIDEDIT-1129: migrate to alma linux 8 #331

Merged
merged 8 commits into from
May 23, 2024
Merged

GRIDEDIT-1129: migrate to alma linux 8 #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
82597d8
Bumped versions of all modules - GCC 12
ahmad-el-sayed May 21, 2024
7664863
Make module loading verbose and print debug info
ahmad-el-sayed May 22, 2024
7fbc4d7
Use --verbose and --debug switches
ahmad-el-sayed May 22, 2024
42dae79
Use newly installed netCDF v4.9.2 that actually has CMake support
ahmad-el-sayed May 23, 2024
68e00e3
Fix gcc-12 warnings that are treated as errors
ahmad-el-sayed May 23, 2024
63d44bc
Added curl module
ahmad-el-sayed May 23, 2024
c811fdd
Revert "Added curl module"
ahmad-el-sayed May 23, 2024
dc0f788
Try loading module curl/8.8.0_gcc12.2.0
ahmad-el-sayed May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ jobs:

name: ${{ inputs.platform }}-${{ inputs.build_type }}

# The default compiler on macos is clang, switch to gcc 11. Specifying the version is necessary.
# The default compiler on macos is clang, switch to gcc. Specifying the version is necessary.
# It seems like gcc and g++ are symbolic links to the default clang and clang++ compilers, respectively.
# CMAKE_CXX_COMPILER_ID will evaluate to AppleClang rather than GNU on macos.
env:
CC: gcc-11
CXX: g++-11
CC: gcc-12
CXX: g++-12

# Build steps
steps:
Expand Down
2 changes: 1 addition & 1 deletion libs/MeshKernel/src/Operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ namespace meshkernel
}

bool inRange = false;
UInt startRange;
UInt startRange = 0;
for (auto n = start; n < end; n++)
{
if (!IsEqual(vec[n].x, separator) && !inRange)
Expand Down
9 changes: 5 additions & 4 deletions scripts/module_load.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Script that is meant to be sourced in the CI
# It includes the necessary module loads to build MeshKernel on Deltares Linux machines

module load cmake/3.23.1_gcc11.3.0
module load gcc/11.3.0
module load boost/1.81.0_gcc11.3.0
module load netcdf/v4.9.1_gcc11.3.0
module --verbose load gcc/12.2.0_gcc12.2.0
module --verbose load cmake/3.26.4_gcc12.2.0
module --verbose load boost/1.83.0_gcc12.2.0
module --verbose load netcdf/4.9.2_gcc12.2.0
module --verbose load curl/8.8.0_gcc12.2.0
Loading