GRIDEDIT-1407 add mkernel_mesh2d_get_property api #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
reviewed
Sep 2, 2024
Comment on lines
392
to
394
| /// Returns the value of the property | ||
| // [[nodiscard]] std::vector<double> GetProperty(Property property) const; | ||
|
|
There was a problem hiding this comment.
I guess sonarcloud will complain about this, commend out code.
Comment on lines
+1479
to
+1483
| if (static_cast<size_t>(geometryList.num_coordinates) < values.size()) | ||
| { | ||
| throw meshkernel::MeshKernelError("GeometryList with wrong dimensions"); | ||
| } | ||
| std::copy(values.begin(), values.end(), geometryList.values); |
There was a problem hiding this comment.
Is this snippet common to both cases?
Comment on lines
390
to
391
| /// | ||
| /// @param [in] property The property to retrive |
There was a problem hiding this comment.
You probably already have an email about the typo
BillSenior
reviewed
Sep 2, 2024
Comment on lines
+1324
to
+1326
| /// @param[in] propertyValue The value representing the specific property | ||
| /// @param[in] dimension The dimension of the specified property | ||
| /// @returns Error code |
There was a problem hiding this comment.
dimension should be an out parameter
BillSenior
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.