GRIDEDIT-1516 Fixed bug in node classification and updated unit test #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacarniato
approved these changes
Dec 17, 2024
| #include "MeshKernel/Utilities/Utilities.hpp" | ||
| #include "MeshKernel/Exceptions.hpp" | ||
|
|
||
| void meshkernel::Print(const std::vector<Point>& nodes, const std::vector<Edge>& edges, std::ostream& out) |
There was a problem hiding this comment.
Do you need to keep these functions?
There was a problem hiding this comment.
No, we do not need them, but it makes it easy to view a mesh. And we do not have to re-implement them each time they are needed (which is quite often)
| } | ||
| } | ||
|
|
||
| void meshkernel::Print(const std::vector<double>& xNodes, |
There was a problem hiding this comment.
Do you need to keep these functions?
Also added file missing in previous Jira item This file was not required for normal execution of mesh kernel only help in debugging
BillSenior
force-pushed
the
feature/GRIDEDIT-1516_node_classification_error
branch
from
8853b6a to
98c7462
Compare
lucacarniato
deleted the
feature/GRIDEDIT-1516_node_classification_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added file missing in previous Jira item
This file was not required for normal execution of mesh kernel only help in debugging