Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIDEDIT-798: Support macOS arm64 #112

Merged
merged 8 commits into from
Jan 8, 2024
Merged

GRIDEDIT-798: Support macOS arm64 #112

merged 8 commits into from
Jan 8, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Nov 21, 2023

Let's see if it requires patches.

@@ -3,14 +3,14 @@ name: Build and test on macos
on:
push:
branches:
- master
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find.. copy and paste error from my end

@@ -48,7 +48,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: "3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd like to be consistent across all platforms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert this. There's a dedicated issue for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 not available on arm64. Will set to again 3.10.

@ahmad-el-sayed ahmad-el-sayed changed the title Try building on macos-arm as well. Support macOS arm64 Jan 8, 2024
@ahmad-el-sayed ahmad-el-sayed changed the title Support macOS arm64 GRIDEDIT-798: Support macOS arm64 Jan 8, 2024
@ahmad-el-sayed ahmad-el-sayed marked this pull request as ready for review January 8, 2024 11:53
@ahmad-el-sayed ahmad-el-sayed merged commit 13fc5c9 into main Jan 8, 2024
10 checks passed
@evetion evetion mentioned this pull request Jan 9, 2024
@ahmad-el-sayed ahmad-el-sayed deleted the feature/macos-arm branch February 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants