Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default autodiff to false #1832

Closed
visr opened this issue Sep 20, 2024 · 0 comments · Fixed by #1835
Closed

Default autodiff to false #1832

visr opened this issue Sep 20, 2024 · 0 comments · Fixed by #1835
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Sep 20, 2024

There is a performance issue with autodiff. That should be investigated, but I suggest we default to false for the release, since on the latest Dommel model the difference is 30 mins vs 47 seconds.
@visr visr added core Issues related to the computational core in Julia v1.0 labels Sep 20, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Sep 20, 2024
@visr visr mentioned this issue Sep 23, 2024
Open
visr added a commit that referenced this issue Sep 23, 2024
@visr
Default to finite difference calculation of the Jacobian
1249784 
Fixes #1832
@visr visr mentioned this issue Sep 23, 2024
Merged
@visr visr closed this as completed in a25c96f Sep 23, 2024
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default to finite difference calculation of the Jacobian Deltares/Ribasim
1 participant
@visr