Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to concentration #1660

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Listen to concentration #1660

merged 7 commits into from
Jul 29, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Jul 25, 2024

Fixes #1610.

It turns out this needed some fixes of #1267, as names of tables like Basin / concentration_external where not generated and read properly.

@SouthEndMusic SouthEndMusic requested a review from visr July 25, 2024 14:52
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some minor comments.

core/src/read.jl Outdated Show resolved Hide resolved
core/src/read.jl Outdated Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic merged commit 2ec955c into main Jul 29, 2024
20 checks passed
@SouthEndMusic SouthEndMusic deleted the listen_to_concentration branch July 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listen to substance and concentration for control
2 participants