Not so auto update #1959
Merged
Not so auto update #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evetion do we need to use another module? And have you seen such a PicklingError before? |
|
I updated the module load command to the currently available module, and updated to GCC 12. Also fixed some mypy unused ignores. But there seems to be several more issues that need to be fixed. This looks like an installation failure of typeguard that I see locally. Explicitly adding with pixi didn't seem to help. A On CI this fails with a pickling error I tried rolling back from pandera 0.21 to 0.20 but it didn't seem to help. |
|
I can reproduce the CI error, not your typeguard one. |
|
Yeah neither can I, that is just pixi environment installation sometimes going wrong leading to this kind of error. |
```
ValidationError Traceback (most recent call last)
File a:\repo\ribasim\Ribasim\models\see.py:1
----> 1 ribasim_testmodels.trivial_model()
File A:\repo\ribasim\Ribasim\python\ribasim_testmodels\ribasim_testmodels\trivial.py:9, in trivial_model()
7 def trivial_model() -> Model:
8 """Trivial model with just a basin, tabulated rating curve and terminal node."""
----> 9 model = Model(
10 starttime="2020-01-01",
11 endtime="2021-01-01",
12 crs="EPSG:28992",
13 results=Results(subgrid=True, compression=False),
14 use_validation=True,
15 )
17 # Convert steady forcing to m/s
18 # 2 mm/d precipitation, 1 mm/d evaporation
19 precipitation = 0.002 / 86400
File a:\repo\ribasim\Ribasim\.pixi\envs\dev\Lib\site-packages\pydantic\main.py:214, in BaseModel.__init__(self, **data)
212 # `__tracebackhide__` tells pytest and some other tools to omit this function from tracebacks
213 __tracebackhide__ = True
--> 214 validated_self = self.__pydantic_validator__.validate_python(data, self_instance=self)
215 if self is not validated_self:
216 warnings.warn(
217 'A custom validator is returning a value other than `self`.\n'
218 "Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.\n"
219 'See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.',
220 stacklevel=2,
221 )
ValidationError: 1 validation error for Model
Value error, Can't do inplace setting when converting from DataFrame to GeoDataFrame [type=value_error, input_value={'starttime': '2020-01-01... 'use_validation': True}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.10/v/value_error
```
evetion
reviewed
Dec 5, 2024
|
🎉 |
evetion
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monthly updates failed. This does them manually and fixes the reasons they failed.