Refactor Model initialization
#528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
changed the title
Model initialization
vers-w
reviewed
Jan 16, 2025
src/initialize_model.jl
Outdated
Comment on lines
193
to
194
| area = cell_data.x_length .* cell_data.y_length, | ||
| slope = land_slope, |
There was a problem hiding this comment.
Would suggest to move these parameters to LandGeometry for aligning sbm and sbm_gwf with sediment.
vers-w
reviewed
Jan 16, 2025
src/initialize_model.jl
Outdated
| land_indices = inds_land_map2river, | ||
| lake_indices = lake_data.inds_lake_map2river, | ||
| allocation_area_indices = river_allocation_area_inds, | ||
| cell_area = cell_data.x_length[inds_land_map2river] .* |
There was a problem hiding this comment.
Would suggest to move this parameter to RiverGeometry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #523
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
masterAdditional Notes (optional)
Some general bits of code advise (opinion):
ALL_CAPSso that they are recognizable as global constants