Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique tide/cmems bc files with multiple polyfiles in modelbuilder #1070

Closed
2 tasks done
veenstrajelmer opened this issue Jan 17, 2025 · 0 comments · Fixed by #1071
Closed
2 tasks done

unique tide/cmems bc files with multiple polyfiles in modelbuilder #1070

veenstrajelmer opened this issue Jan 17, 2025 · 0 comments · Fixed by #1071

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jan 17, 2025 •
edited
Loading

when looping over multiple polyfiles in modelbuilder, all merged CMEMS get overwritten. Therefore, add polyfile basename to merged cmems file.

Todo:

  • Update this in cmems_nc_to_bc() and interpolate_tide_to_bc()
  • also requires update of the modelbuilder example notebook, where the cmems bc file are read
@veenstrajelmer veenstrajelmer changed the title prevent overwiting of cmems files with multiple polyfiles in modelbuilder unique cmems files with multiple polyfiles in modelbuilder Jan 17, 2025
This was referenced Jan 17, 2025
Open
Closed
@veenstrajelmer veenstrajelmer linked a pull request Jan 17, 2025 that will close this issue
unique cmems bc files with multiple polyfiles in modelbuilder #1071
Merged
@veenstrajelmer veenstrajelmer changed the title unique cmems files with multiple polyfiles in modelbuilder unique tide/cmems bc files with multiple polyfiles in modelbuilder Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unique cmems bc files with multiple polyfiles in modelbuilder Deltares/dfm_tools
1 participant
@veenstrajelmer