Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for waq in modelbuilder example script #504

Closed
4 tasks done
veenstrajelmer opened this issue Sep 4, 2023 · 0 comments · Fixed by #601
Closed
4 tasks done

support for waq in modelbuilder example script #504

veenstrajelmer opened this issue Sep 4, 2023 · 0 comments · Fixed by #601

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 4, 2023

Merely adding no3 to

for varkey in ['so','thetao','uo','vo','zos']:
and tracerbndNO3 to
list_quantities = ['waterlevelbnd','salinitybnd','temperaturebnd','uxuyadvectionvelocitybnd'] # when supplying two waterlevelbnds to FM (tide and steric) with other quantities in between, dimrset>=2.24.00 is required or else "ERROR : update_ghostboundvals: not all ghost boundary flowlinks are being updated" is raised (https://issuetracker.deltares.nl/browse/UNST-7011). Two waterlevelbnds need to share same physical plifile in order to be appended (https://issuetracker.deltares.nl/browse/UNST-5320).
does not work. It raises ValueError: 30 of requested pli points are out of bounds (valid longitude range -68.5 to -67.75, valid latitude range 11.75 to 12.75)

TODO:

  • increase spatial buffer in download_CMEMS, e.g. no3 dataset has resolution of 1/4 degree while thetao has 1/12 degree (for both reanalysis as forecast).
  • in dfmt.modelbuilde.cmems_nc_to_bc() there is a unnecessary replace for tide, remove this
  • update modelbuilder example script and notebook to contain also waq example
  • return available keys in conversion_dict if incorrect key is supplied

Follow up: #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant