Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model exec batfile #1030

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Fix model exec batfile #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0c1f51
updated notebook path
veenstrajelmer Oct 18, 2024
4b54adb
updated path in create_model_exec_files
veenstrajelmer Oct 18, 2024
3572c58
updated whatsnew.md
veenstrajelmer Oct 18, 2024
8bb67e0
sane hisinterval
veenstrajelmer Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dfm_tools/modelbuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,10 @@ def generate_bat_file(dimr_model, dimrset_folder=None):
set partitions={nproc}

rem Partition the network and mdu
call %dimrset_folder%\x64\dflowfm\scripts\run_dflowfm.bat "--partition:ndomains=%partitions%:icgsolver=6" %MDU_file%
call %dimrset_folder%\x64\bin\run_dflowfm.bat "--partition:ndomains=%partitions%:icgsolver=6" %MDU_file%

rem Execute the simulation
call %dimrset_folder%\x64\dimr\scripts\run_dimr_parallel.bat %partitions% {dimr_name}
call %dimrset_folder%\x64\bin\run_dimr_parallel.bat %partitions% {dimr_name}

rem To prevent the DOS box from disappearing immediately: enable pause on the following line
pause
Expand Down
146 changes: 73 additions & 73 deletions docs/notebooks/modelbuilder_example.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/whats-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fix
- fixed cmems-nrt insitu again by dropping station with varying coordinates again in [#1023](https://github.com/Deltares/dfm_tools/pull/1023)
- update executable paths in batfile created by `dfmt.create_model_exec_files()` in [#1030](https://github.com/Deltares/dfm_tools/pull/1030)


## 0.29.0 (2024-09-27)
Expand Down
Loading