Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

998 remove escape for not monotonic cmems insitu datasets #999

Merged
merged 2 commits into from
Sep 18, 2024
Merged

998 remove escape for not monotonic cmems insitu datasets #999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f55f973
removed code for non-monotonic cmems observation files
veenstrajelmer Sep 18, 2024
8752a95
drop removal of MO_TS_TG_ANDRATX that had varying lat/lon coordinates…
veenstrajelmer Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions dfm_tools/observations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,7 @@ def cmems_ssh_read_catalog(source, overwrite=True):
bool_tidegauge = index_history_pd["file_name"].str.contains("/history/TG/")
bool_slev = index_history_pd["parameters"].str.contains("SLEV")
index_history_pd = index_history_pd.loc[bool_tidegauge & bool_slev]

# drop andratx station, lat/lon vary over time in nrt dataset
# TODO: remove this exception when the CMEMS nrt dataset is cleaned up
bool_moving = index_history_pd["file_name"].str.contains("MO_TS_TG_ANDRATX")
index_history_pd = index_history_pd.loc[~bool_moving]


# generate geom and geodataframe
assert (index_history_pd["geospatial_lon_min"] == index_history_pd["geospatial_lon_max"]).all()
assert (index_history_pd["geospatial_lat_min"] == index_history_pd["geospatial_lat_max"]).all()
Expand Down Expand Up @@ -598,17 +593,6 @@ def cmems_ssh_retrieve_data(row, dir_output, time_min=None, time_max=None,
# drop all unnecessary vars
ds = ds.drop_vars(["SLEV_QC","TIME_QC","DEPH_QC","LATITUDE","LONGITUDE","STATION","POSITION"], errors="ignore")

# check order of time variable
if not ds.time.to_pandas().index.is_monotonic_increasing:
# TODO: happens in some MO_TS_TG_RMN-* stations in NRT dataset, asked to fix
# Genova, Imperia, LaSpezia, Livorno, Ravenna, Venice
stat_name = row.loc["station_name_unique"]
print(f"[{stat_name} NOT MONOTONIC] ", end="")
del ds
os.remove(file_data_raw)
return
# ds = ds.sortby("time")

# slice on time extent
ds = ds.sel(time=slice(time_min, time_max))
if len(ds.time) == 0:
Expand Down
Loading