Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydromt_version in predefined data catalog files #708

Closed
2 tasks done
DirkEilander opened this issue Jan 8, 2024 · 0 comments · Fixed by #741
Closed
2 tasks done

Add hydromt_version in predefined data catalog files #708

DirkEilander opened this issue Jan 8, 2024 · 0 comments · Fixed by #741
Assignees
Labels
Bug Something isn't working DataCatalog & DataAdapters issues related to the DataCatalog and DataAdapters V1
Milestone

Comments

@DirkEilander
Copy link
Contributor

DirkEilander commented Jan 8, 2024

HydroMT version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT.

Reproducible Example

Apart from the artifact_data catalog, all predefined data catalogs do not yet use the hydromt_version meta key. This should be added to raise better errors when loading unsupported datasets.

This is not documented, but already supported in the code, see:

# check version required hydromt version

Current behaviour

when loading deltares_data with hydromt v0.8 you get a random ValueError

hydromt.DataCatalog('deltares_data')

>> ValueError: pcr_globwb: Missing required path argument

Desired behaviour

RunTimeError: Data catalog requires Hydromt Version ...

Additional context

No response

@DirkEilander DirkEilander added Bug Something isn't working DataCatalog & DataAdapters issues related to the DataCatalog and DataAdapters labels Jan 8, 2024
@savente93 savente93 added this to the v1.0 milestone Jan 10, 2024
@Tjalling-dejong Tjalling-dejong self-assigned this Jan 10, 2024
@savente93 savente93 added V1 and removed V1 labels Jan 11, 2024
@savente93 savente93 modified the milestones: v1.0, 2024 - Q1 Jan 11, 2024
@savente93 savente93 modified the milestones: v1.0 beta, v1.0 alpha May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working DataCatalog & DataAdapters issues related to the DataCatalog and DataAdapters V1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants