Issue #996 Add Weekly CI job that runs the acceptance tests #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manangka
changed the title
|
Manangka
changed the title
JoerivanEngelen
approved these changes
Sep 9, 2025
Contributor
JoerivanEngelen
left a comment
JoerivanEngelen
left a comment
There was a problem hiding this comment.
2 comments, approving in advance.
| notifierSettings = emailNotifier { | ||
| email = """ | ||
| joeri.vanengelen@deltares.nl | ||
| luitjan.slooten@deltares.nl |
Contributor
There was a problem hiding this comment.
Probably caused by copypasta, but I think this e-mail isn't active anymore.
Collaborator
Author
There was a problem hiding this comment.
I indeed copy paste this part. His mail is still present in multiple places in the pipeline code. I will update the notifier mails in 1 go in a separate PR
Comment on lines
+20
to
+21
| param("env.access_key", "%credentialsJSON:2978988a-493b-44ed-9fcb-6cd6d2c2c673%") | ||
| param("env.secret_access_key", "%credentialsJSON:409a55c0-b2e7-438c-98dd-f0404b83cabb%") |
Contributor
There was a problem hiding this comment.
Just double-checking: You are not publicly exposing secret access keys here?
Collaborator
Author
There was a problem hiding this comment.
Nope. This is a Teamcity parameter that maps internally to the actual keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
Description
This commit adds a weekly job that runs the acceptance tests.
A main "Test" job is created that is triggered every sunday. This job triggers its dependencies.
For now that is only the "acceptance tests" job. However any future weekly jobs can be attached to it.
I would also make sense to eventually put the "Pixi update" under this job as that is a weekly job as well
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes