Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

392-multi_link_redundancy-adjust-calculating-diff_time-or-diff_length #393

Conversation

sahand-asgarpour
Copy link
Contributor

@sahand-asgarpour sahand-asgarpour commented Mar 28, 2024

Issue addressed

Solves #392

What has been done?

For the multi_link_redundancy, adjusted the calculation of diff_time or diff_length

Checklist

  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@sahand-asgarpour sahand-asgarpour linked an issue Mar 28, 2024 that may be closed by this pull request
2 tasks
@sahand-asgarpour sahand-asgarpour requested a review from ArdtK March 28, 2024 13:07
@sahand-asgarpour sahand-asgarpour self-assigned this Mar 28, 2024
@sahand-asgarpour sahand-asgarpour added this to the Sprint 2024 Q1.2 milestone Mar 28, 2024
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two acceptance tests are failing because the key length does not seem to be found. Therefore the branch cannot be merged.

@Carsopre Carsopre merged commit c348912 into master Mar 28, 2024
2 of 3 checks passed
@Carsopre Carsopre deleted the 392-multi_link_redundancy-adjust-calculating-diff_time-or-diff_length branch March 28, 2024 20:05
Carsopre added a commit that referenced this pull request Apr 12, 2024
…ngth (#393)

* chore: difference in alt and base transport time is corrected

* chore: _row.get("avgspeed", None) added and row.get("length", None)

* chore: dict.get(key, None) introduced

* chore: (WeighingEnum.TIME.config_value not in columns added + edge_remove condition updated

---------

Co-authored-by: Carles S. Soriano Perez <carles.sorianoperez@deltares.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi_link_redundancy: Adjust calculating diff_time or diff_length
2 participants