Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

599 remove outdated setup of adaptation attempts #603

Merged
merged 3 commits into from
Nov 28, 2024
Merged

599 remove outdated setup of adaptation attempts #603

merged 3 commits into from
Nov 28, 2024

Conversation

MatthiasHauthDeltares
Copy link
Contributor

@MatthiasHauthDeltares MatthiasHauthDeltares commented Nov 27, 2024 •
edited
Loading

Issue addressed

Solves #

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@MatthiasHauthDeltares MatthiasHauthDeltares linked an issue Nov 27, 2024 that may be closed by this pull request
Remove outdated setup of adaptation attempts #599
Closed
ArdtK
ArdtK approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ArdtK ArdtK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the enum later on.

ra2ce/analysis/analysis_config_data/enums/analysis_damages_enum.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Carsopre do you think it is worth keeping the enum if there's only 1 option left? Also for adaptation I don't create an enum.

@MatthiasHauthDeltares MatthiasHauthDeltares merged commit 291962e into master Nov 28, 2024
3 checks passed
@MatthiasHauthDeltares MatthiasHauthDeltares deleted the 599-remove-outdated-setup-of-adaptation-attempts branch November 28, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArdtK ArdtK ArdtK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove outdated setup of adaptation attempts
2 participants
@MatthiasHauthDeltares @ArdtK