Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/601 create sandbox example input for adaptation run #645

Conversation

MatthiasHauthDeltares
Copy link
Contributor

Issue addressed

Solves #

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

ArdtK and others added 30 commits November 27, 2024 13:26
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' of https://github.com/Deltares/ra2ce into feat/604-adaptation-extend-analysis-config-dataclass-and-reader
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
ArdtK and others added 21 commits December 4, 2024 12:49
… into feat/601-create-sandbox-example-input-for-adaptation-run
… into feat/601-create-sandbox-example-input-for-adaptation-run

# Conflicts:
#	tests/test_data/acceptance_test_data/output/analyses.ini
…adaptation-run

# Conflicts:
#	ra2ce/analysis/adaptation/adaptation.py
#	ra2ce/analysis/adaptation/adaptation_option.py
#	ra2ce/analysis/adaptation/adaptation_option_analysis.py
#	ra2ce/analysis/adaptation/adaptation_option_collection.py
#	ra2ce/analysis/analysis_config_data/analysis_config_data.py
#	ra2ce/analysis/analysis_config_data/analysis_config_data_reader.py
#	ra2ce/analysis/analysis_input_wrapper.py
#	tests/analysis/adaptation/conftest.py
#	tests/analysis/adaptation/test_adaptation_option.py
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the output is cleared.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to clear the output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, i think?

@MatthiasHauthDeltares MatthiasHauthDeltares merged commit 5103791 into master Dec 11, 2024
4 checks passed
@MatthiasHauthDeltares MatthiasHauthDeltares deleted the feat/601-create-sandbox-example-input-for-adaptation-run branch December 11, 2024 12:01
@MatthiasHauthDeltares MatthiasHauthDeltares restored the feat/601-create-sandbox-example-input-for-adaptation-run branch December 12, 2024 14:50
@MatthiasHauthDeltares MatthiasHauthDeltares deleted the feat/601-create-sandbox-example-input-for-adaptation-run branch December 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants