Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 646 write adaptation to file #650

Merged
merged 10 commits into from
Dec 12, 2024
Merged

feat: 646 write adaptation to file #650

merged 10 commits into from
Dec 12, 2024

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Dec 10, 2024 •
edited
Loading

Issue addressed

Solves #646

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Add "geometry" to the output gdf so it can be exported.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

N.A.

@ArdtK ArdtK linked an issue Dec 10, 2024 that may be closed by this pull request
Adaptation: write results from adaptation into a gdf #646
Closed
2 tasks
@ArdtK ArdtK changed the title chore: add geometry logic feat: 646 write adaptation to file Dec 10, 2024
@ArdtK ArdtK marked this pull request as ready for review December 11, 2024 07:21
Carsopre
Carsopre requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation on the test should be improve. I have a feeling it will not work when using the AnalysisResultWrapperExporter, so it's better so have a proper test for it.

ra2ce/analysis/adaptation/adaptation.py Outdated Show resolved Hide resolved
tests/analysis/adaptation/test_adaptation.py Outdated Show resolved Hide resolved
tests/analysis/adaptation/test_adaptation.py Outdated Show resolved Hide resolved
Carsopre
Carsopre approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I still think you should be comparing the results of the generated results (you have the reference data "by hand") the issue can be merged.
Please keep in mind there are two remarks (one affects two similar pieces of code) to be addressed before merging.

ra2ce/analysis/adaptation/adaptation_option.py Outdated Show resolved Hide resolved
tests/analysis/adaptation/test_adaptation.py Outdated Show resolved Hide resolved
tests/analysis/adaptation/test_adaptation_option_collection.py Show resolved Hide resolved
@ArdtK
Copy link
Contributor Author

ArdtK commented Dec 12, 2024

Although I still think you should be comparing the results of the generated results (you have the reference data "by hand") the issue can be merged. Please keep in mind there are two remarks (one affects two similar pieces of code) to be addressed before merging.

Added an assert on the file content, although I'm not convinced it should be part of this test. We have other tests to check if the export itself goes well.

@ArdtK ArdtK merged commit 5351a6a into master Dec 12, 2024
1 of 2 checks passed
@ArdtK ArdtK deleted the fix/646-adaptation-write-results-from-adaptation-into-a-gdf branch December 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carsopre Carsopre Carsopre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptation: write results from adaptation into a gdf
2 participants
@ArdtK @Carsopre