Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get the build passing #8077

Merged
merged 2 commits into from
Aug 5, 2024
Merged

get the build passing #8077

merged 2 commits into from
Aug 5, 2024

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Aug 1, 2024

Explanation:
Builds started failing running pip check with

Rtree 1.2.0 is not supported on this platform

If I pip install pip==24.1, pip check tells me everything is fine

If I pip install pip==24.2, pip check tells me Rtree 1.2.0 is not supported on this platform

For the moment I suggest we pin pip to get things moving again, but I'll try and see if I can find out exactly what the issue is. To me this looks like a false failure though.

@chris48s chris48s changed the title trigger a build get the build passing Aug 1, 2024
@chris48s
Copy link
Member Author

chris48s commented Aug 1, 2024

I reckon this might be pypa/pip#12884

@chris48s
Copy link
Member Author

chris48s commented Aug 1, 2024

OK, so turns out this is actually fixed in rtree==1.3.0
New solution: upgrade rtree, leave pip as it was.

@@ -1691,12 +1689,6 @@ sentry-sdk==2.1.1 \
# via
# -r requirements/../cdk/lambdas/wdiv-s3-trigger/requirements/base.in
# -r requirements/base.in
setuptools==69.2.0 \
Copy link
Member Author

@chris48s chris48s Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-generated the requirements files using:

pip-compile --allow-unsafe --generate-hashes --output-file=requirements/constraints.txt --strip-extras requirements/constraints.in --upgrade-package rtree

to re-lock requirements/constraints.txt

and then

pip-compile --allow-unsafe --generate-hashes --output-file=requirements/base.txt --strip-extras requirements/base-constrained.in --upgrade-package rtree

to re-lock requirements/base.txt

That seemed right 🤞

I'm not sure why pip-tools took setuptools out of the lockfile here. Tbh, your pip-tools setup on this repo is pretty fiendish and also a bit under-specified. I think I'm going to need a bit of a primer on this before I can really do substantial work on the dependency tree on this repo. From memory, I feel like whether to include setuptools in lock files is something pip-tools went back on forth on a bit in different releases. There is no specific pip-tools version specified in the requirements or docs. I locked this using pip-tools==7.4.1. Let me know if you want me to re-lock using a different pip-tools version. Also if I didn't use the right combination of commands..

@chris48s chris48s marked this pull request as ready for review August 1, 2024 12:14
@symroe symroe merged commit b116834 into master Aug 5, 2024
3 checks passed
@symroe symroe deleted the build20240801 branch August 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants