-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get the build passing #8077
get the build passing #8077
Conversation
I reckon this might be pypa/pip#12884 |
OK, so turns out this is actually fixed in |
@@ -1691,12 +1689,6 @@ sentry-sdk==2.1.1 \ | |||
# via | |||
# -r requirements/../cdk/lambdas/wdiv-s3-trigger/requirements/base.in | |||
# -r requirements/base.in | |||
setuptools==69.2.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-generated the requirements files using:
pip-compile --allow-unsafe --generate-hashes --output-file=requirements/constraints.txt --strip-extras requirements/constraints.in --upgrade-package rtree
to re-lock requirements/constraints.txt
and then
pip-compile --allow-unsafe --generate-hashes --output-file=requirements/base.txt --strip-extras requirements/base-constrained.in --upgrade-package rtree
to re-lock requirements/base.txt
That seemed right 🤞
I'm not sure why pip-tools took setuptools
out of the lockfile here. Tbh, your pip-tools setup on this repo is pretty fiendish and also a bit under-specified. I think I'm going to need a bit of a primer on this before I can really do substantial work on the dependency tree on this repo. From memory, I feel like whether to include setuptools in lock files is something pip-tools went back on forth on a bit in different releases. There is no specific pip-tools version specified in the requirements or docs. I locked this using pip-tools==7.4.1
. Let me know if you want me to re-lock using a different pip-tools
version. Also if I didn't use the right combination of commands..
Explanation:
Builds started failing running
pip check
withIf I
pip install pip==24.1
,pip check
tells me everything is fineIf I
pip install pip==24.2
,pip check
tells meRtree 1.2.0 is not supported on this platform
For the moment I suggest we pin pip to get things moving again, but I'll try and see if I can find out exactly what the issue is. To me this looks like a false failure though.