Adapt sidebar to TopicStore and Forums #985
Conversation
|
|
|
3b) Same thing happens on |
Adapt sidebar to TopicStore and Forums
| } | ||
| }); | ||
| } | ||
|
|
||
| res.json(expose(topicKeys)(topicDoc.toJSON())); | ||
| res.json(exposeTopic(topic, req.user)); |
There was a problem hiding this comment.
Hey @slifszyc, @mjlescano is it right to write a response before the topic gets saved? It didn't use to be like this (bejore there used to be res.json(200) inside the callback for the topic.save call.
There was a problem hiding this comment.
It is inside the topic.save(function (err, saved) { callback, see #985 (diff)
There was a problem hiding this comment.
Then I guess it's wrong on what I saw when rebasing my PR. I guess I should've looked closer. Please be sure to check my PR as well
No description provided.