Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics_summary_col_conversion.tsv #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deevdevil88
Copy link
Contributor

mino types in the count_mtric

mino types in the count_mtric
@bio-la
Copy link
Collaborator

bio-la commented Jan 8, 2024

hi @deevdevil88, thanks for starting this PR.
we need more testing on this feature to ensure we can deal with different cellranger versions outputs.
in particular your suggested modification to the summary column conversion will break the current working version, which is why we need to clearly deal with cellranger-version dependencies.
see

def parse_10x_cellranger_multi(path_df,path_col='metrics_summary_path'):

can you fix this? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants