Move functions into its own header file. #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… symbol clashes when it gets used in multiple segments or from multiple libraries.
… symbol clashes when it gets used in multiple segments or from multiple libraries.
|
This commit doesn't appear to build... In the past I've a fair number of issues getting libraries to work on arduinos. I'm not that familiar with embedded C, but I have been advised many times that header-only libraries are simpler to build, and that's been my experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out the functions; as on the ESP32 compiler we otherwise get symbol clashes when it gets used in multiple segments or from multiple libraries.