Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier support to be more portable #783

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bastien-boussouf
Copy link

@bastien-boussouf bastien-boussouf commented Mar 7, 2025

Description

While working on the repository, I figured I could probably make prettier and linting a bit more portable across platforms (I'm working on a mix of Windows / WSL / Linux setups).

The changes I propose are mainly directed at having an .editorconfig file that prettier automatically picks when running and that will also apply to the user IDE. I also propose to align the versions used in the workflow to the one declared in the package.json file.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Sorry, something went wrong.

@bastien-boussouf bastien-boussouf marked this pull request as ready for review March 27, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant