Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vectors, dot above, double dot above #90

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

vinix38
Copy link
Contributor

@vinix38 vinix38 commented Sep 2, 2023

The following were added :

  • vectors for all letters, uppercase and lowercase
  • dot above for all lowercase letters and a few greek letters
  • double dot above for all lowercase letters and a few greek letters

This is more of a suggestion. Feel free to modify this pull request to bring it inline with project requirements.

dictionary.txt Outdated Show resolved Hide resolved
@vinix38
Copy link
Contributor Author

vinix38 commented Sep 9, 2023

When using my phone, shortcuts using • do work properly.
However, using ASCII characters seems sensible to me, as it is easier to use and remember. I have made the changes you envisioned. I have removed dotted Greek letters at the moment, because I am not sure whether they are relevant and how to handle their shortcuts.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Sep 10, 2023

When using my phone, shortcuts using • do work properly.

You are right, it seems I put it in wrong when testing. I assumed it was a similar issue to #13 but it seems like even that is working again now in the latest version of Gboard.

Edit: some from #13 are working but it seems like not all of them (eg. parentheses seem to still be broken)

@DenverCoder1 DenverCoder1 merged commit d707747 into DenverCoder1:master Sep 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants