Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring4 hibernate4 migration #26

Merged
merged 61 commits into from
Dec 22, 2015
Merged

Spring4 hibernate4 migration #26

merged 61 commits into from
Dec 22, 2015

Conversation

wjase
Copy link

@wjase wjase commented Nov 19, 2015

Bumped versions of spring and hibernate.
Refactored transaction behaviour.
Started work on converting xml config to java config.
Added dao/config test

wjase and others added 29 commits November 17, 2015 21:18
…ic property method in favour of spring properties.
… properties test using the new properties configuration.xml - which will go once the java config takes over.
@stevespringett
Copy link
Member

Jason,
Thanks for the pull request. Excellent work! Is there anything more left to do for this? Also, there seems to be a merge conflict.

@wjase
Copy link
Author

wjase commented Dec 16, 2015

Mostly done now. Need to fix up where the log is written using spring boot.
Would be interested for folks to have a play in case I've inadvertently changed some behaviour

stevespringett added a commit that referenced this pull request Dec 22, 2015
@stevespringett stevespringett merged commit 6114e71 into DependencyTrack:master Dec 22, 2015
@stevespringett
Copy link
Member

Jason, free free to add yourself as a developer in the pom. Would you like to be added to https://www.owasp.org/index.php/OWASP_Dependency_Track_Project#tab=Acknowledgements ?

@wjase wjase deleted the spring4_hibernate4_migration branch January 25, 2016 10:57
@stevespringett
Copy link
Member

Most functionality no longer works - especially from a clean database. Transactions are missing which are absolutely essential, and the complexity of hibernate session handling is unnecessary. I'm going to rip out most of the refactoring of hibernate query changes as most of the changes have introduced defects.

@wjase
Copy link
Author

wjase commented Feb 17, 2016

Hi Steve,

Have seen a similar issue in the last few days with spring boot and jsp.
Mvn spring-boot:run works but running the jar does not.

I'll Try and get it sorted as soon as I can.

2 options I know of.

  1. keep jsp and do some jiggery pokery to make Spring Boot Happy
  2. Convert to Thymeleaf

I'm inclined to keep jsp until I've sorted out the persistence issues
and then think about what you'd like me to do.
I've just converted a mammoth internal web app at tyro from war to
executable jar with jsps and it was quite a slog - but I should be able
to leverage my lessons learned and scars obtained to make this one faster...

Cheers,

Jason

----- Reply message -----
From: "Steve Springett" notifications@github.com
To: "stevespringett/dependency-track" dependency-track@noreply.github.com
Cc: "Jason Wraxall" jason@cybernostics.com.au
Subject: [dependency-track] Spring4 hibernate4 migration (#26)
Date: Tue, Feb 16, 2016 09:49

Most functionality no longer works - especially from a clean database. Transactions are missing which are absolutely essential, and the complexity of hibernate session handling is unnecessary. I'm going to rip out most of the refactoring of hibernate query changes as most of the changes have introduced defects.


Reply to this email directly or view it on GitHub:
#26 (comment)

@lock
Copy link

lock bot commented Sep 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants