-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VDR export containing non-vulnerable components #2878
Conversation
Fixes DependencyTrack#2788 Signed-off-by: nscuro <nscuro@protonmail.com>
dependencies.add(dependency); | ||
} | ||
|
||
return dependencies; | ||
} | ||
|
||
private static List<Dependency> convertDirectDependencies(final String directDependenciesRaw) { | ||
private static List<Dependency> convertDirectDependencies(final String directDependenciesRaw, final List<Component> components) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MixedMutabilityReturnType: This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.
private static List<Dependency> convertDirectDependencies(final String directDependenciesRaw, final List<Component> components) { | |
private static ImmutableList<Dependency> convertDirectDependencies(final String directDependenciesRaw, final List<Component> components) { |
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2878.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2878.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
Description
This PR fixes the CycloneDX VDR export to not contain components that are not affected by any vulnerability.
Addressed Issue
Fixes #2788
Additional Details
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly