Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoints for bulk tagging & un-tagging of projects #3894

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jun 29, 2024

Description

Adds REST endpoints for bulk tagging & un-tagging of projects.

image

Addressed Issue

Relates to #586

Additional Details

Bulk operations are currently limited to 100 projects per request. We can raise this limit if users need it. But for a beginning it's better to stay conservative since limiting it later would mean a breaking change.

Both POST and DELETE endpoints are implemented to be atomic operations.

Portfolio ACLs are considered:

  • Trying to tag projects the user has no access to is a no-op
  • Trying to un-tag projects the user has no access to is a no-op

There will be no HTTP 403 response if tagging or un-tagging of inaccessible projects is attempted.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Jun 29, 2024
@nscuro nscuro added this to the 4.12 milestone Jun 29, 2024
Copy link

codacy-production bot commented Jun 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 92.22% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a0407b4) 21903 16650 76.02%
Head commit (c41717f) 21963 (+60) 16714 (+64) 76.10% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3894) 90 83 92.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro mentioned this pull request Jun 29, 2024
2 tasks
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro force-pushed the tag-untag-project-endpoints branch from a466b6a to c41717f Compare June 30, 2024 11:01
@nscuro nscuro merged commit a2b2a66 into DependencyTrack:master Jun 30, 2024
11 checks passed
@nscuro nscuro deleted the tag-untag-project-endpoints branch June 30, 2024 13:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant